Skip to content

fix(#1822): test directory capable of watching before presenting it #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

alex-courtis
Copy link
Member

fixes #1822

@alex-courtis alex-courtis merged commit 87961d3 into master Jan 9, 2023
@alex-courtis alex-courtis deleted the 1822-powershell-no-events branch January 9, 2023 02:59
@chomosuke
Copy link
Collaborator

@alex-courtis I was just about to merge master into my branch and noticed that it was force pushed? Is this intentional? About a week worth of commits were overwritten and I think this would break PackerUpdate as well.

@alex-courtis
Copy link
Member Author

Yes. I made a huge mistake and pushed commits I should not have.

Forcing master is a very bad idea; in 10 years of using git that is the first and last time I force.

Should be resolved: #1906

Packer was fine with defaults (depth 1) however it did complain ^

alex-courtis added a commit that referenced this pull request Jan 10, 2023
…watching before presenting it (#1905)

* fix(#1822): test directory capable of watching before presenting it (#1901)

* feat(git): support `DA` state

Co-authored-by: Alexander Courtis <alex@courtis.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not start the fs_event watcher for path ... : EPERM
2 participants