1831 remove windows executable functionality #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Dec 31, 2022
|
|
||
| return M.is_windows_exe(ext) | ||
| end | ||
|
|
gegoune
approved these changes
Dec 31, 2022
There are only a few places they are actually used. I was suprised to learn that trash doesn't work on macOS or windows... |
alex-courtis
deleted the
1831-remove-windows-executable-functionality
branch
|
Trash itself doesn't but there is another tool, it might even be shipped with macOS, but I never had a need to use it so can't recall its name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1831