feat: make fs actions async #1863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the fs actions are currently implemented as synchronous operations. This works fine with a small set of files and directories, but will block the user for a long time when working with a larger scale of files, e.g. removing a folder containing deep hierarchy and plenty of files like
node_modules
in javascript world.The proposal is to replace the actions with the asynchronous version, mainly by using async luv apis as much as possible. This might lead to great improvements on user experience as the fs operations never block nvim. But it is also a potential breaking change if some users already rely on the synchronous behavior, I'm still not sure about it.