Skip to content

fix: reduce signcolumn/foldcolumn from window width #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: reduce signcolumn/foldcolumn from window width #1688

merged 1 commit into from
Oct 31, 2022

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Oct 26, 2022

@pleshevskiy
Copy link

pleshevskiy commented Oct 26, 2022 •
edited
Loading

I've checked and it works! Thanks!

image

alex-courtis
alex-courtis requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good:

20221029_135419 441x477

Please be more defensive:

  • win_getid may return 0 which will result in an incorrect result from getwininfo
  • getwininfo may return an empty list

textoff is OK as it is "guaranteed" to be a number for a successful result.

@ssiyad ssiyad force-pushed the fix/render_fullname_signcolumn branch from 67b344c to 9418b80 Compare October 30, 2022 21:27
@ssiyad ssiyad requested a review from alex-courtis October 30, 2022 21:28
@ssiyad
fix: reduce signcolumn/foldcolumn from window width
777279f 
ref: `:h getwininfo()`

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
@ssiyad ssiyad force-pushed the fix/render_fullname_signcolumn branch from 9418b80 to 777279f Compare October 30, 2022 21:32
alex-courtis
alex-courtis approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully, thank you for the contribution.

lua/nvim-tree/renderer/components/full-name.lua
local width = fn.strdisplaywidth(fn.substitute(line, "[^[:print:]]*$", "", "g"))
if width < fn.winwidth(0) then
local text_width = fn.strdisplaywidth(fn.substitute(line, "[^[:print:]]*$", "", "g"))
local win_width = effective_win_width()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@alex-courtis alex-courtis merged commit fba9751 into nvim-tree:master Oct 31, 2022
@ssiyad ssiyad deleted the fix/render_fullname_signcolumn branch October 31, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssiyad @pleshevskiy @alex-courtis