fix(#1629): nvim start with file named *NvimTree* opens tree instead of buffer #1634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
reviewed
Oct 9, 2022
lua/nvim-tree.lua
Outdated
Comment on lines
261
to
267
| -- Session that left a NvimTree Buffer opened, reopen with it | ||
| local existing_tree_wins = find_existing_windows() | ||
| if existing_tree_wins[1] then | ||
| api.nvim_set_current_win(existing_tree_wins[1]) | ||
| end | ||
|
|
||
| if should_open or existing_tree_wins[1] ~= nil then |
There was a problem hiding this comment.
i think this is needed for user using sessions
There was a problem hiding this comment.
maybe a better fix would be to change the matching string to NvimTree_
There was a problem hiding this comment.
Good catch; I didn't think of nvim sessions, just user calling setup multiple times.
Added a util to check that the buffer name matches and that it is a real file. We can't test file type as it's not imported via default sessionoptions.
@barrett-ruth I'd be grateful for a re-test.
…instead of buffer" This reverts commit e713607.
|
Raised #1639 to be completed in a separate branch. |
|
@alex-courtis works great for me. |
kyazdani42
approved these changes
Oct 10, 2022
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
… instead of buffer (nvim-tree#1634) * fix(nvim-tree#1629): nvim start with file named *NvimTree* opens tree instead of buffer * Revert "fix(nvim-tree#1629): nvim start with file named *NvimTree* opens tree instead of buffer" This reverts commit e713607. * fix(nvim-tree#1629): nvim start with file named *NvimTree* treats file as tree * fix(nvim-tree#1629): nvim start with file named *NvimTree* treats file as tree
alex-courtis
deleted the
1629-cannot-start-with-buffer-named-NvimTree
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1629
find_existing_windows misidentifies a buffer named
*NvimTree*as the tree's buffer.setup->on_enter->find_existing_windowsis the only codepathsetup∴ this may be removed