Skip to content

fix(#1494): git showUntracked value and log #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

AxLauri
Copy link
Contributor

@AxLauri AxLauri commented Aug 13, 2022

  • should_show_untracked evaluates non-boolean status.showUntrackedFiles

  • git.Runner status logging nil values removed before concat

closes #1494

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • stylua fixes
  • simplify clean_log

@AxLauri AxLauri force-pushed the 1494-git-untracked-log branch from ade3c00 to 6878252 Compare August 14, 2022 18:25
@AxLauri AxLauri requested a review from alex-courtis August 14, 2022 18:51
@AxLauri
Copy link
Contributor Author

AxLauri commented Aug 14, 2022

  • stylua check should be good now
  • simplified clean_log to use tbl_filter as suggested

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for asking after the first review, but can you please move clean_log to lua/nvim-tree/utils.lua

function M.array_remove_nils(array)

@AxLauri AxLauri force-pushed the 1494-git-untracked-log branch 2 times, most recently from 7ef1d2d to 52c71ac Compare August 15, 2022 02:41
* should_show_untracked correctly evaluates status.showUntrackedFiles

* git.Runner:_run_git_job removes nils before logging args
@AxLauri AxLauri force-pushed the 1494-git-untracked-log branch from 52c71ac to 93c23cb Compare August 15, 2022 02:49
@AxLauri AxLauri requested a review from alex-courtis August 15, 2022 02:53
@AxLauri
Copy link
Contributor Author

AxLauri commented Aug 15, 2022

1st PR and new to Lua, so thanks for bearing with me.

@alex-courtis
Copy link
Member

1st PR and new to Lua, so thanks for bearing with me.

It is a pleasure to work with you.

@alex-courtis alex-courtis merged commit 09a5126 into nvim-tree:master Aug 15, 2022
@AxLauri AxLauri deleted the 1494-git-untracked-log branch August 15, 2022 05:21
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
* should_show_untracked correctly evaluates status.showUntrackedFiles

* git.Runner:_run_git_job removes nils before logging args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git runner logging error during table concat with nil
2 participants