-
-
Notifications
You must be signed in to change notification settings - Fork 626
fix(#1494): git showUntracked value and log #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- stylua fixes
- simplify clean_log
ade3c00
to
6878252
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for asking after the first review, but can you please move clean_log to lua/nvim-tree/utils.lua
function M.array_remove_nils(array)
7ef1d2d
to
52c71ac
Compare
* should_show_untracked correctly evaluates status.showUntrackedFiles * git.Runner:_run_git_job removes nils before logging args
52c71ac
to
93c23cb
Compare
1st PR and new to Lua, so thanks for bearing with me. |
It is a pleasure to work with you. |
* should_show_untracked correctly evaluates status.showUntrackedFiles * git.Runner:_run_git_job removes nils before logging args
should_show_untracked evaluates non-boolean status.showUntrackedFiles
git.Runner status logging nil values removed before concat
closes #1494