fix(#1480): break symlink cycle on find-file, search-node

lua/nvim-tree/actions/finders/find-file.lua

@@ -27,12 +27,20 @@ function M.fn(fname)
 
   local line = core.get_nodes_starting_line()
 
+  local absolute_paths_searched = {}
+
   local found = Iterator.builder(core.get_explorer().nodes)
     :matcher(function(node)
       return node.absolute_path == fname_real or node.link_to == fname_real
     end)
     :applier(function(node)
       line = line + 1
+
+      if vim.tbl_contains(absolute_paths_searched, node.absolute_path) then
+        return
+      end
+      table.insert(absolute_paths_searched, node.absolute_path)
+
       local abs_match = vim.startswith(fname_real, node.absolute_path .. utils.path_separator)
       local link_match = node.link_to and vim.startswith(fname_real, node.link_to .. utils.path_separator)
 

lua/nvim-tree/actions/finders/search-node.lua

@@ -7,42 +7,54 @@ local find_file = require("nvim-tree.actions.finders.find-file").fn
 
 local M = {}
 
-local function search(dir, input_path)
-  local path, name, stat, handle, _
+local function search(search_dir, input_path)
+  local realpaths_searched = {}
 
-  if not dir then
+  if not search_dir then
     return
   end
 
-  handle, _ = uv.fs_scandir(dir)
-  if not handle then
-    return
-  end
+  local function iter(dir)
+    local realpath, path, name, stat, handle, _
 
-  name, _ = uv.fs_scandir_next(handle)
-  while name do
-    path = dir .. "/" .. name
+    handle, _ = uv.fs_scandir(dir)
+    if not handle then
+      return
+    end
 
-    stat, _ = uv.fs_stat(path)
-    if not stat then
-      break
+    realpath, _ = uv.fs_realpath(dir)
+    if not realpath or vim.tbl_contains(realpaths_searched, realpath) then
+      return
     end
+    table.insert(realpaths_searched, realpath)
+
+    name, _ = uv.fs_scandir_next(handle)
+    while name do
+      path = dir .. "/" .. name
 
-    if not filters.should_ignore(path) then
-      if string.find(path, "/" .. input_path .. "$") then
-        return path
+      stat, _ = uv.fs_stat(path)
+      if not stat then
+        break
       end
 
-      if stat.type == "directory" then
-        path = search(path, input_path)
-        if path then
+      if not filters.should_ignore(path) then
+        if string.find(path, "/" .. input_path .. "$") then
           return path
         end
+
+        if stat.type == "directory" then
+          path = iter(path)
+          if path then
+            return path
+          end
+        end
       end
-    end
 
-    name, _ = uv.fs_scandir_next(handle)
+      name, _ = uv.fs_scandir_next(handle)
+    end
   end
+
+  return iter(search_dir)
 end
 
 function M.fn()