feat(marks): add navigation (next, previous, select) #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
force-pushed
the
feat/add-mark-navigation
branch
2 times, most recently
from
3041d15 to
8ce1931
Compare
8 tasks
kyazdani42
force-pushed
the
feat/add-mark-navigation
branch
from
8ce1931 to
3efc241
Compare
kyazdani42
changed the title
kyazdani42
force-pushed
the
feat/add-mark-navigation
branch
6 times, most recently
from
dbeb11c to
6f24b60
Compare
kyazdani42
force-pushed
the
feat/add-mark-navigation
branch
from
6f24b60 to
f446831
Compare
alex-courtis
approved these changes
Jul 16, 2022
There was a problem hiding this comment.
Tested OK:
- file and folder
- from nvim-tree
- from buffer
- update_focused_file.enabled
- 0, 1, n marks
Type number and <Enter> or click with the mouse (q or empty cancels): is odd. I cannot make mouse selection work in a clean setup or my full setup. Not really related.
An option might be to use the location list to do the navigation, however that would probably result in a more (complicated) implementation with little benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will edit the file if the node is a file, and focus the folder in the tree if the node is a folder.
Added:
implements part of #1413