-
-
Notifications
You must be signed in to change notification settings - Fork 626
feat(bookmarks): add bookmark feature #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
92ceb2c
to
4b9040a
Compare
4b9040a
to
579785f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users will complain when they see that marks do not yet do anything. Here's a branch that hides marks behind a "feature flag" feat/bookmarks...feat/bookmarks-amc
At some point can do more with the marks API e.g.
set_marks(table)
toggle_mark(string)
add_mark(string)
remove_mark(string)
In the far future we could define an official API e.g.
require "nvim-tree-api".toggle()
require "nvim-tree-api".get_marks()
@alex-courtis i don't think hiding this behind a feature flag is useful, i think first leaving a simple api for the users so people can start building integration with the marks would be better. Even if people complain, they can just script something and open a PR if they feel the feature they write would be useful in nvim-tree. |
Sounds good. Feature flagging functionality is not nice and creates future work. Having a useful API should be enough to keep people happy. |
254753a
to
874b18e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NvimTreeBookmark
in :help
1eefa6e
to
5b652dc
Compare
I've added the docs, lets merge this and add the features in followup PRs |
Uses the signcolum to display the mark status. Marks are saved in memory for now, we'll see if we want to implement a filesystem save for the marks (would not be hard). Added `m` keybinding to toggle the mark on the node. Users can call `require "nvim-tree.marks".get_marks()` which returns a list of absolute paths.
5b652dc
to
2e96a4b
Compare
Yes. Long running branches are undesirable. I'll get to the follow up PRs on the weekend. |
Uses the signcolum to display the mark status.
Marks are saved in memory for now, we'll see if we want to implement a
filesystem save for the marks (would not be hard).
Added
m
keybinding to toggle the mark on the nodeUsers can call
require "nvim-tree.marks".get_marks()
which returns alist of absolute paths.
superseeds #612
TODO:
Fixes #221
Fixes #51
Fixes #595
Fixes #509