Skip to content

refactor(actions): move actions into semantic modules #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

kyazdani42
Copy link
Member

The purpose of this PR is to cleanup the actions module which got a bit overwhelming when searching for a particular module.

@kyazdani42 kyazdani42 requested a review from alex-courtis July 9, 2022 10:41
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Did not test this refactor.

Groupings make sense. Maybe some small name tweaks:
change-dir -> root
fs-operations -> fs
open-file/open-file.lua -> node/open.lua

@@ -5,43 +5,51 @@ local M = {}

local Actions = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first instinct is was to move each of these to an dispatch.lua in each directory however that adds no value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess so :) i still want to improve this module since it's a bit clunky imo.

@kyazdani42 kyazdani42 force-pushed the refactor/actions/move-files-into-modules branch from 54a67e2 to 19a60c0 Compare July 10, 2022 07:47
@kyazdani42 kyazdani42 merged commit 831f115 into master Jul 10, 2022
@kyazdani42 kyazdani42 deleted the refactor/actions/move-files-into-modules branch July 10, 2022 07:47
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants