-
-
Notifications
You must be signed in to change notification settings - Fork 625
feat(actions): expand all under folder #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works.
Froze for 15 mins when expanding ~/src
but that is not surprising.
Needs a safety valve e.g.
"Expand halted after opening 500 folders"
That could be hardcoded or an option.
600f8d8
to
4b89159
Compare
i think 100/200 folders would already be good enough, i'll try something out |
4b89159
to
5b2d203
Compare
@@ -190,6 +190,9 @@ require'nvim-tree'.setup { -- BEGIN_DEFAULT_OPTS | |||
global = false, | |||
restrict_above_cwd = false, | |||
}, | |||
expand_all = { | |||
max_folder_discovery = 300, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not too sure about the option name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_folder_expand
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll see if this makes sense for user as it is.
300 is good; it stops after a few seconds. |
5b2d203
to
fa271ed
Compare
fa271ed
to
010df50
Compare
fixes #1289 #380
@alex-courtis i'd like a review on the doc and the binding to make sure its okay, because this feature will freeze neovim if used in the wrong place.