Skip to content

feat(actions): expand all under folder #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2022
Merged

feat(actions): expand all under folder #1292

merged 4 commits into from
May 29, 2022

Conversation

kyazdani42
Copy link
Member

fixes #1289 #380
@alex-courtis i'd like a review on the doc and the binding to make sure its okay, because this feature will freeze neovim if used in the wrong place.

@kyazdani42 kyazdani42 requested a review from alex-courtis May 26, 2022 12:03
@kyazdani42 kyazdani42 changed the title feat(actions): expand all action feat(actions): expand all under folder May 26, 2022
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works.

Froze for 15 mins when expanding ~/src but that is not surprising.

Needs a safety valve e.g.
"Expand halted after opening 500 folders"
That could be hardcoded or an option.

@kyazdani42
Copy link
Member Author

i think 100/200 folders would already be good enough, i'll try something out

@@ -190,6 +190,9 @@ require'nvim-tree'.setup { -- BEGIN_DEFAULT_OPTS
global = false,
restrict_above_cwd = false,
},
expand_all = {
max_folder_discovery = 300,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too sure about the option name here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_folder_expand ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll see if this makes sense for user as it is.

@alex-courtis
Copy link
Member

i think 100/200 folders would already be good enough, i'll try something out

300 is good; it stops after a few seconds.

@kyazdani42 kyazdani42 merged commit 3a95c5a into master May 29, 2022
@kyazdani42 kyazdani42 deleted the feat/expand-all branch May 29, 2022 09:15
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand_all to expand all folders to make live_filter more awesome
2 participants