feat(renderer): allow placing git icons after filename

[kyazdani42]

This is a first draft, i'd like to improve the code a bit before merging because it's not pretty as it is, but usable.
This also change the behavior for special icons, which will display icons normally instead of the default file icon.

TODO:

• config option documentation
• improve the algorithms for placing the git icon
• add the git icon for the symlinks also

implements #246, #1069 and #72, #1217

[gegoune]

Will check if master is the same but seeing some odd highlighting on that PR.

that was with:

vim.g.nvim_tree_icons = {
  git = {
    unstaged = 'M',

Adding more chars, like:

vim.g.nvim_tree_icons = {
  git = {
    unstaged = '[M]',

shifts highlight even more:

[kyazdani42]

i guess, see my comment before :) this is not perfect yet, the algorithms are very clunky as it is.

[gegoune]

Wasn't complaining, just reporting, PR is in progress, of course. :)

[kyazdani42]

@gegoune could you give it another try ? i've fixed multiple issues and also added icons for symlinks :)

[gegoune]

@gegoune could you give it another try ? i've fixed multiple issues and also added icons for symlinks :)

Highlighting issue seems to be fixed now.

Unrelated, and I think there already is an issue for it, but why not put those markers in signcolumn?

[alex-courtis]

Nice. I'll give this a test / review on the weekend.

[kyazdani42]

the signcolumn is another issue, i'll implement this after :) one thing at a time !

[alex-courtis]

This definitely works. Tested files and folders: before, after, foo

[alex-courtis]

RE symlink git icons:

They are not really part of this change. They can be made to work with some tweaking of node-builders.link, conditionally using the absolute or link path and get_dir_git_status for folder links.

Raised #1217. I've pushed a WIP branch that I'll get back to later.

[kyazdani42]

@alex-courtis do you want me to remove the code that adds the git icons for symlinks ? It works fine on my end though.

[alex-courtis]

@alex-courtis do you want me to remove the code that adds the git icons for symlinks ? It works fine on my end though.

No! I've tested it. Once we resolve #1217 everything will display correctly.