Skip to content

#1166 validate config #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 26, 2022
Merged

#1166 validate config #1195

merged 18 commits into from
Apr 26, 2022

Conversation

kyazdani42
Copy link
Member

@alex-courtis there are a few edge cases that were not covered
somehow #1194 but i cannot reproduce
and when an option can have different types (such a view.width/view.height)

@kyazdani42 kyazdani42 requested a review from alex-courtis April 24, 2022 12:43
@kyazdani42 kyazdani42 force-pushed the #1166-validate-config branch from b6d7697 to e6d1938 Compare April 24, 2022 12:44
@alex-courtis
Copy link
Member

somehow #1194 but i cannot reproduce

That's a use case I did not account for: value table with defaults, rather than empty.

I'll think about options. Perhaps the ignore list is still a good idea.

@alex-courtis
Copy link
Member

alex-courtis commented Apr 25, 2022

and when an option can have different types (such a view.width/view.height)

I'm not sure that is a good idea, however we can work with it.

@alex-courtis
Copy link
Member

Let's try this again:

  • functions are allowed as values; I have added a warning to the doc
  • integer indexed tables are not checked, as they are not strongly typed and have variable length contents

@alex-courtis
Copy link
Member

Tested:

@kyazdani42 kyazdani42 merged commit 3ac4432 into master Apr 26, 2022
@kyazdani42
Copy link
Member Author

let see if this works 😄

@kyazdani42 kyazdani42 deleted the #1166-validate-config branch April 30, 2022 12:33
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants