-
-
Notifications
You must be signed in to change notification settings - Fork 626
#1166 validate config #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
#1166 validate config #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6d7697
to
e6d1938
Compare
Closed
That's a use case I did not account for: value table with defaults, rather than empty. I'll think about options. Perhaps the ignore list is still a good idea. |
I'm not sure that is a good idea, however we can work with it. |
Let's try this again:
|
Tested:
|
alex-courtis
approved these changes
Apr 25, 2022
let see if this works 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alex-courtis there are a few edge cases that were not covered
somehow #1194 but i cannot reproduce
and when an option can have different types (such a view.width/view.height)