#837 find file symlinks fixes #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alex-courtis
commented
Mar 20, 2022
lua/nvim-tree/actions/find-file.lua
Outdated
| local stat, _ = uv.fs_stat(node.absolute_path) | ||
| if not stat then | ||
| break | ||
| end |
There was a problem hiding this comment.
Extra safety check cannot hurt.
alex-courtis
commented
Mar 20, 2022
lua/nvim-tree/actions/find-file.lua
Outdated
| return i | ||
| end | ||
| local abs_match = vim.startswith(fname_real, node.absolute_path .. utils.path_separator) | ||
| local real_match = vim.startswith(fname_real, real_path .. utils.path_separator) |
There was a problem hiding this comment.
We could keep a "real path" on the node, however that seems too complicated.
There was a problem hiding this comment.
There is a link_to attributes for symlinks on node, maybe this is what you would like to use here ?
There was a problem hiding this comment.
There is a
link_toattributes for symlinks on node, maybe this is what you would like to use here ?
Goot thinking. I'll rework on the weekend.
There was a problem hiding this comment.
It is now simpler, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#837 and #1092 exposed some remaining issues with symlink resolution. This covers the find-file cases.
Branched off #1092. Please review / merge that first.