Set target window whenever we open "open" a visible tree #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the target window to be used (with a disabled pick window) is the one that was "focused" when the tree was first opened. So, if you let the tree open, the splits and open file are going to target the original window. This is counter intuitive and annoying if what you want to achieve is to open a file in a split. This minor change updates the target window whenever we try to open the tree, that's executed whenever we focus the tree, so the behaviour is now that the splits and open_file are executed against the previously focussed buffer.
kyazdani42
approved these changes
Mar 18, 2022
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the target window to be used (with a disabled pick window) is the one that was "focused" when the tree was first opened.
So, if you let the tree open, the splits and open file are going to target the original window.
This is counter intuitive and annoying if what you want to achieve is to open a file in a split.
This minor change updates the target window whenever we try to open the tree, that's executed whenever we focus the tree, so the behavior is now that the splits and open_file are executed against the previously focused buffer.