Skip to content

#1050 #1068 various default options tweaks #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 18, 2022
Merged

#1050 #1068 various default options tweaks #1074

merged 10 commits into from
Mar 18, 2022

Conversation

alex-courtis
Copy link
Member

  • remove defaults from bug template
  • script to update defaults in readme, help
  • move the following to DEFAULT_OPTS
    • view
    • trash
    • window picker
  • add empty mapping defaults; this bugged me when I started, as I didn't know where to put my mappings

@alex-courtis alex-courtis mentioned this pull request Mar 12, 2022
Closed
alex-courtis
alex-courtis commented Mar 12, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml
@@ -63,108 +63,36 @@ body:
value: |
vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = '/tmp/nvt-min/site/pack'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylua

@alex-courtis alex-courtis changed the title #1050 #1068 various default options #1050 #1068 various default options tweaks Mar 12, 2022
alex-courtis
alex-courtis commented Mar 12, 2022
View reviewed changes
README.md
@@ -108,68 +108,74 @@ highlight NvimTreeFolderIcon guibg=blue
```lua
-- init.lua

-- following options are the default
-- empty setup using defaults: add your own options
Copy link
Member Author

@alex-courtis alex-courtis Mar 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have been very useful for me when starting out with nvim-tree.

I thought you had to specify all the options 🤦

kyazdani42
kyazdani42 approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebase it :)

@alex-courtis
Copy link
Member Author

just rebase it :)

ready

@alex-courtis
Copy link
Member Author

Please merge this one first @kyazdani42 so that we don't get any further conflicts ;)

@kyazdani42 kyazdani42 merged commit 20797a8 into nvim-tree:master Mar 18, 2022
@alex-courtis alex-courtis mentioned this pull request Mar 19, 2022
Closed
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
@alex-courtis
nvim-tree#1050 nvim-tree#1068 various default options tweaks (nvim-tr…
5655243 
…ee#1074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyazdani42 kyazdani42 kyazdani42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-courtis @kyazdani42