File logging #1053
Merged
File logging #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Mar 6, 2022
| @@ -100,11 +122,20 @@ function Runner.run(opts) | |||
| list_ignored = opts.list_ignored, | |||
| timeout = opts.timeout or 400, | |||
| output = {}, | |||
| _done = false | |||
| rc = nil, -- -1 indicates timeout | |||
There was a problem hiding this comment.
Care has been taken to not alter the functionality or flow of control here. _done -> rc is the only significant change.
alex-courtis
commented
Mar 6, 2022
lua/nvim-tree/log.lua
Outdated
| function M.setup(opts) | ||
| M.config = opts.log | ||
| if M.config and M.config.enable and M.config.types then | ||
| M.path = string.format("%s/nvim-tree-%s-%s.log", vim.env.HOME, os.date("%H:%M:%S"), vim.env.USER) |
There was a problem hiding this comment.
Time is enough to uniquely identify the file. Date is too long.
kyazdani42
reviewed
Mar 6, 2022
lua/nvim-tree/log.lua
Outdated
| function M.setup(opts) | ||
| M.config = opts.log | ||
| if M.config and M.config.enable and M.config.types then | ||
| M.path = string.format("%s/nvim-tree-%s-%s.log", vim.env.HOME, os.date("%H:%M:%S"), vim.env.USER) |
There was a problem hiding this comment.
could we store that in vim.stdpath('data') ? I don't like programs not respecting XDG :)
There was a problem hiding this comment.
Using vim.fn.stdpath("cache") which is where nvim, packer and lsp put their logs.
Also printed this path at startup so that the user is aware.
|
I would be grateful for a successful test (notably the git bits) by @gegoune and @kyazdani42 before we merge this. There are a lot of moving parts. |
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
* add file logging infrastructure * log git runner operations * log configuration and mappings * document file logging infrastructure * style fixes * stylua fixes * document log file locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to log to a file. One file per nvim session is created.
Some logging has been added:
Configuration
Git runner
I have elected to put the logs in the user's home rather than /tmp, so that they don't forget about them. They may forget to turn logging off and many large files will accumulate.