Close help on q/close instead of ignore keypress #1043
Conversation
| if view.is_help_ui() and action == 'close' then | ||
| action = 'toggle_help'; | ||
| end |
There was a problem hiding this comment.
you toggle the help with g?, why does this need another binding ?
There was a problem hiding this comment.
I think it's more natural to think of it as opening help, then using the generic close to close the current view. Most other "views" in vim works like this. e.g :help vs :q. I hit 'q' every time I am on the help view to close it and feel stuck on that screen until I remember it's the same command to close it as open it.
I don't really see a reason why 'close' should stop working just because the help view is open - having an escape out that works as expected on both screens seems pretty helpful to the user.
No doubt you are comfortable with the current behaviour - but I'm fairly sure new and casual users would agree with the 'q to close either screen' sentiment.
Co-authored-by: Shane Hird <shane.hird@csgicorp.com>
I believe this is better matches expectations when pressing 'q' on the help ui.