feat: add sort_by option to sort files by modification time

[bdwiel]

Fixes #1039 for files only. I'll wait for feedback on whether you like this feature or not before investigating why it's not working on directories. I was thinking that directories will always be sorted above files at the same level. So for each node, show sorted(directories) followed by sorted(files/symlinks). What do you think?

[bdwiel]

I created separate functions for sorting by name or modification time. I also made it pull the modification time in the builders instead of the comparator. This looks cleaner and should ensure each node calls fs_stat just once :-)

[kyazdani42]

almost good, some code smell.

[kyazdani42]

thanks, nice feature. would be nice to add a toggle action for this too :)

[siduck]

@kyazdani42
sort_by = "modification_time"

This option sorts by the last modified files. I want the opposite, is there any option for it? like showing last modified files/dirs at the end

So files/dirs which were created first will be shown first and the latest files/dirs at last.

sort_by = "modified_time_new" or "modified_time_old"

There could be two options for this ( the modified_time_new is the current one )

[alex-courtis]

sort_by = "modified_time_new" or "modified_time_old"

That's pretty specific. We could be more generic with something like sort_reverse = false. Please raise a feature request.

[siduck]

sort_by = "modified_time_new" or "modified_time_old"

That's pretty specific. We could be more generic with something like sort_reverse = false. Please raise a feature request.

i doubt if sort_reverse would be helpful for other sort options like sort by name, extension etc

The current modification_time can be renamed to modified_time_new and a new sort option could be added modified_time_old ( old files on top )

or new_files , old_files

[alex-courtis]

i doubt if sort_reverse would be helpful for other sort options like sort by name, extension etc

The current modification_time can be renamed to modified_time_new and a new sort option could be added modified_time_old ( old files on top )

or new_files , old_files

Please raise a feature request, with a PR gratefully appreciated.

sort_reverse may not make sense for the current options (although it does work) however can be used for future sort options.