Float window for full filenames has wrong bg

[simonmandlik]

Description

Setting full_name = true, there is an inconsistent color of the background of the floating window, depending on culopt settting in neovim.

Neovim version

NVIM v0.10.0-dev-2274+g1d5f86f69-Homebrew
Build type: Release
LuaJIT 2.1.1703358377

Operating system and version

macOS 14.4.1

Windows variant

No response

nvim-tree version

81eb8d5

Clean room replication

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
vim.opt.culopt = "number"
_G.setup = function()
    require("nvim-tree").setup {
        view = { cursorline = true },
        renderer = { full_name = true, }
    }
end

Steps to reproduce

1. nvim -nu /tmp/nvt-min.lua
2. :NvimOpenTree

Expected behavior

I would expect to either show no cursorline at all (there are no numbers in nvim tree), or the floating window bg to be consistent with cursorline bg for shorter items.

Actual behavior

Screen.Recording.2024-04-11.at.11.34.32.mov

[alex-courtis]

Reproduced:

[alex-courtis]

&cursorline is always set for the float, but only for the tree window when view.cursorline is set.

&cursorlineopt is always set to "both" for the tree window and never for the float window.

That can be fixed.

In full-name show() we'll need to set cursorline cursorlineopt=both only when view.cursorline is set.

This surfaces a problem: when cursorline is not shown in the float, it shows the default float background. This is different from the tree and will need to be explicitly set. Many View.winopts.winhl should be applied.