Add an option to modify tree padding/indentation

[charbelnicolas]

I think adding an indent/padding to the tree would be nice.

Describe the solution you'd like

Add an option to modify the padding/indent of children in the tree (components/padding.lua)

function M.get_padding(depth, idx, nodes_number, node, markers) local padding = " "

Describe alternatives you've considered

Editing the source file directly and adding a space " ".

Before:

After:

It looks a bit nicer!

[alex-courtis]

Add an option to modify the padding/indent of children in the tree (components/padding.lua)

view.width.padding can take a function, a similar callback may be added.

Possibility: pass the node to the callback.

[samuelnihoul]

I will try to make the PR.

[GCrispino]

@alex-courtis is this still relevant? I can see you can set view.width.padding to be either a numer, string, or a function.

The only remaining thing is that it doesn't take any arguments, which is what you suggested in this comment: #2023 (comment)

Is this why you haven't closed this?

[alex-courtis]

@alex-courtis is this still relevant? I can see you can set view.width.padding to be either a numer, string, or a function.

The only remaining thing is that it doesn't take any arguments, which is what you suggested in this comment: #2023 (comment)

Is this why you haven't closed this?

Good spot, that was added immediately before this. It works, but it's only far right padding.
We could add a similar left padding option, allowing far left and far right padding.

renderer.indent_width handles the cumulative indent width before each child node, default 1.

I think that's enough.

Why did I talk about taking a node parameter and a function? I think padding worked quite differently at the time; it's had several iterations over the years.

[GCrispino]

Good spot, that was added immediately before this. It works, but it's only far right padding. We could add a similar left padding option, allowing far left and far right padding.

This makes sense 👍🏼 . How/where would this option be defined though? Would we keep view.width.padding as the right padding and add something like view.width.left_padding for the left padding? That is maybe not super clear but I don't think we can change view.width.padding to view.width.right_padding for backwards compatibility's sake, right?

[alex-courtis]

That is maybe not super clear but I don't think we can change view.width.padding to view.width.right_padding for backwards compatibility's sake, right?

This happens a lot with the options, we get trapped.

The strategy is to change the options schema, but silently migrate the old. See
https://github.com/nvim-tree/nvim-tree.lua/blob/master/lua/nvim-tree/legacy.lua#L6
and :help nvim-tree-legacy-opts

We could even change to something like:

  view = {
    width = {
      padding = {
        left = 2,
        right = 2,
      },
    },