<C-x> opens file in vertical split when buffer is modified and vim.opt.hidden is false

[dave-kennedy]

Description

As described in title :)

Neovim version

NVIM v0.8.3
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

Ubuntu 22.04

nvim-tree version

08a0aa1

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.hidden = false

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {}
end

Steps to reproduce

1. nvim -nu /tmp/nvt-min.lua
2. :NvimTreeToggle
3. Open any file and modify it but don't save it
4. <C-w> h to go back to tree window
5. Select any other file and hit <C-x>

Expected behavior

New file opens in horizontal split.

Actual behavior

New file opens in vertical split.

[alex-courtis]

That is a rarely trodden codepath. Please test the following fix:

cd /path/to/nvim-tree.lua
git pull
git checkout 2003-obey-split-when-hidden-not-set

[dave-kennedy]

Looks good! Thanks for the quick turnaround!