Fails to display git icons, `Shift+R` removes `git` icons

[hinell]

Neovim-tree-fails-to-display-git-info-2023-02-03_00.36.00.mp4.mov

CTRL+S is bound to :update command

Description

Git icons aren't displayed. If I save an edited file (or remove existing one by dkey) , they appear again (i.e. U symbols) . But when Shift + R is hit (in the NvimTree buffer), all icons disappear.

Neovim version

NVIM v0.9.0-dev-d3355ad
Build type: MinSizeRel
LuaJIT 2.1.0-beta3

Operating system and version

Ubuntu 22.04.1 LTS

nvim-tree version

16a0e3c

Minimal config

        vim.g.loaded_netrw = 1
        vim.g.loaded_netrwPlugin = 1
        require("nvim-tree").setup({
          sort_by = "case_sensitive",
          sync_root_with_cwd = true,
          open_on_tab = false, -- TODO: Open issue to make it new tab 
          open_on_setup = true,
          open_on_setup_file = false,
		  ignore_ft_on_setup={ "help", "man" },
          actions = {
            use_system_clipboard = true
          },
          view = {
            adaptive_size = true,
            side  = "right",
            width = 48
          },
          renderer = {
            group_empty = true,
            icons = {
				webdev_colors = false, 
				git_placement = "after",
				modified_placement = "after",
				glyphs = {
					git = {
						-- Git style symbols
						unstaged  = "U",
						staged    = "A",
						unmerged  = "M",
						renamed   = "R",
						untracked = "?",
						deleted   = "R",
						ignored   = "!"
					}
				}
            }
          },
          filters = {
            dotfiles = false,
          },
          -- Disable all keys to be set up by Legendary 
          remove_keymaps = keystodisable
        })

Steps to reproduce

Not even sure?

Expected behavior

All Git icons sync-ed to the working directory.

Actual behavior

No Git icons

Log

~/.cache/nvim/nvim-tree.log

[2023-02-03 02:20:37] [git] { "git", "-C", "/home/USER/.config/nvim", "rev-parse", "--show-toplevel" }
/home/USER
[2023-02-03 02:20:37] [git] { "git", "-C", "/home/USER", "config", "status.showUntrackedFiles" }
[2023-02-03 02:20:37] [git] running job with timeout 400ms
[2023-02-03 02:20:37] [git] git --no-optional-locks status --porcelain=v1 -z --ignored=matching -u
[2023-02-03 02:20:37] [git] job timed out  /home/USER nil
[2023-02-03 02:22:41] [git] { "git", "-C", "/home/USER/.config/nvim/USER", "rev-parse", "--show-toplevel" }
/home/USER
[2023-02-03 02:22:49] [git] running job with timeout 400ms
[2023-02-03 02:22:49] [git] git --no-optional-locks status --porcelain=v1 -z --ignored=matching -u /home/USER/.config/nvim/USER
 M .config/nvim/USER/keymaps.lua
 M .config/nvim/USER/platform.lua
 M .config/nvim/USER/plugins-legendary.lua
 M .config/nvim/USER/plugins-nvim-tree.lua
 M .config/nvim/USER/plugins-snippets.lua
 M .config/nvim/USER/plugins-ui.lua
 M .config/nvim/USER/plugins.lua
[2023-02-03 02:22:50] [git] done
[2023-02-03 02:22:50] [git] job success    /home/USER /home/USER/.config/nvim/USER

... <git --no-optional ...> repeated several times

[hinell]

I've checked the processes and it turns out that git subprocess simply hangs... It's listed as zombie. The repo isn't huge though.

[tjex]

there's a few things that could help make this clearer.
screenshots would be ace, to see the process of what's happening (git files reappearing).

Also, as you're using the development version of neovim, there could be some quirks.
Lastly, the minimal config file you've included isn't based on the supplied minimal config file.

Did you follow the steps exactly for running neovim from a barebone minimal config with neovim by using this config and running neovim with nvim -nu /tmp/nvt-min.lua?

apart from that, and considering that it is actually a bug, it could make some sense to think about how git consideres deleted files within a repo. That being that a deleted file becomes an unstaged file, as its deletion is a state change that git wants to track. So maybe it's reapearing and being given your symbol for unstaged U, becuase it is indeed an unstaged file and therefore a file to show in the tree.

But the first points of screenshots and confirming that this is happening with a minimal config would be something to check off first.

[tjex]

also as a side note the open_on_setup and related methods have been depreciated in favour of this approach which achieves the same. So it's advisable to switch to this, to save any future wonky behaviour.

[alex-courtis]

Thanks for the diagnostics @tjex

I await the results with interest...

[alex-courtis]

Not a solution, however I am investigating / warning about (timed out) zombies: #1970

[hinell]

@alex-courtis @tjex I've uploaded demo-video, checkout.

[alex-courtis]

I've uploaded demo-video, checkout.

Unfortunately that video "file is corrupt" and cannot play. You might want to try https://asciinema.org/

[alex-courtis]

@hinell I'd be most grateful if you could test this branch. It ceases git integration after 10 timeouts and better handles timed out git processes.

cd /path/to/nvim-tree.lua
git pull
git checkout 1970-handle-git-timeouts-and-zombies

Logging git operations would also be most useful.

[hinell]

@alex-courtis Checkout video againt. I've reuploaded it. The previous one was working well on chrome.

[hinell]

Did you follow the steps exactly for running neovim from a barebone minimal config with neovim by using this config and running neovim with nvim -nu /tmp/nvt-min.lua?

@tjex Here you go.

nvim --clean -nu /tmp/tmp.Wx9tf0h96a/nvt-min.lua

NvimTree-clear-minconfig-2023-02-05_16.13.18.mov

Note: I've DISABLED open_on_setup and DONT use it in all demos above.