Disabling window picker causes splits to garble the layout

[naquad]

Description

When disabling the window_picker NvimTree's open-in-a-split functionality opens new NvimTree windows and tries to create a split there.

Neovim version

NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

Arch Linux 5.19.12-zen1-1-zen

nvim-tree version

2b97063

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]

-- these give 100% reproducibility
-- I've been encountering the issue w/o these settings,
-- although sometimes it was working
vim.o.splitbelow = true
vim.o.splitright = true

-- optional
vim.o.background = 'dark'
vim.cmd [[ color slate ]]

local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {
    actions = {
      open_file = {
        window_picker = {
          enable = false
        }
      }
    }
  }
end

Steps to reproduce

1. Open NeoVIM in the directory containing at least 4 files
2. NvimTreeOpen
3. Request NvimTree to open file1 (<CR>)
4. Switch back to NvimTree
5. Open file2 in the split (<C-x>)
6. Switch back to NvimTree
7. Open file3 in the split
8. Switch back to NvimTree
9. Open file4 in the split
10. Close all windows except any file and NvimTree
11. Switch back to NvimTree
12. Open some other file in a split

Screen recording:

Expected behavior

Expecting NvimTree to open the requested file as a split of another window.

Actual behavior

NvimTree creates the second own window and splits it.

[r7vme]

affects me too, I'm on this commit 4e24505

NVIM v0.8.0-1210-gd367ed9b2

@naquad thanks for creating an issue

[alex-courtis]

Reliably reproduced:

1. :NvimTreeOpen
2. navigate to 1
3. <CR>
4. <C-w>w
5. navigate to 2
6. <C-x>
7. :q
8. <C-w>w
9. navigate to 3
10. <C-x>

Replacing 8 with :NvimTreeFindFile functions as expected.

[alex-courtis]

Possibly related #1675

[alex-courtis]

Reverting to 23a564f before #1626 results in the broken v/h split behaviour, however an extra tree is not opened.

[alex-courtis]

c4ac723 achieved an incorrect split as a side effect.

edit was called instead of a split

nvim-tree.lua/lua/nvim-tree/actions/node/open-file.lua

Line 215 in e94f517

cmd = string.format("edit %s", fname)

The value of lib.target_win_id is stale and refers to the recently closed split.

[alex-courtis]

@naquad @r7vme I will be very grateful if you test this fix:

cd /path/to/nvim-tree.lua
git pull
git checkout 1671-split-fail-no-window-picker

When you're done, checkout master or nightly.

[naquad]

The fix is working as expected :) I've tried my case, right side, custom keys, and various combinations of splits and closed windows.

Screencast with the working version:

[r7vme]

@alex-courtis #1677 fixes issue for me. Thanks 🙏

[alex-courtis]

That's fantastic, thank you both!

I'll let this soak with you for a few days then merge.