File opens on the same nvim-tree window when quit_on_open = true

[Almo7aya]

Description

When opening a file using Telescope or :e [filename] while focusing on the nvim-tree window, the file opens the same window as nvim-tree

Kapture.2022-10-07.at.05.14.26.mp4

Neovim version

NVIM v0.9.0-dev-1214-ge54541f7f-dirty
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version

MacOS 12.6

nvim-tree version

main - 7282f7d

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "kyazdani42/nvim-tree.lua",
      "kyazdani42/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
  require("nvim-tree").setup {
    actions = {
      open_file = {
      quit_on_open = true
    }
  }
}
end

Steps to reproduce

1- nvim -nu /tmp/nvt-min.lua
2- e ./nvt-min.lua
3- :NvimTreeOpen
4- e ./nvt-min.lua

Expected behavior

No response

Actual behavior

No response

[Almo7aya]

It seems that this bug is caused by this line https://github.com/kyazdani42/nvim-tree.lua/blob/master/lua/nvim-tree.lua#L382
after changing both cases to

create_nvim_tree_autocmd("BufWipeout", { pattern = "NvimTree_*", callback = view._prevent_buffer_override })

it started working as expected

[alex-courtis]

Replicated. Does not appear to be a race condition.

Please:

• raise a PR
• test fix with
  • multiple tabs / trees
  • open_on_tab
  • view.float enabled

[Almo7aya]

@alex-courtis sure will test with these cases and open a PR

[Almo7aya]

I did my tests
with multiple tabs it's working fine

when open_on_tab = true and open_on_tab = true and forcing on nvim-tree's window calling :bnext closes the window and jumps to the next buffer not sure if this is the expected behavior, I think both options are conflicting with each other

when view.float is enabled calling :e [filename] while focus is on nvim-tree's window with open_on_tab = true and open_on_tab = true opens the file in a new vsplit

the config i'm using with my fork on it

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvt-min/site]])
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
	require("packer").startup({
		{
			"wbthomason/packer.nvim",
			"almo7aya/nvim-tree.lua",
			"kyazdani42/nvim-web-devicons",
			-- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
		},
		config = {
			package_root = package_root,
			compile_path = install_path .. "/plugin/packer_compiled.lua",
			display = { non_interactive = true },
		},
	})
end
if vim.fn.isdirectory(install_path) == 0 then
	print("Installing nvim-tree and dependencies.")
	vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]])
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
	require("nvim-tree").setup({
		view = {
			float = {
				enable = true,
			},
		},
		open_on_tab = true,
		actions = {
			open_file = {
				quit_on_open = true,
			},
		},
	})
end

vim.api.nvim_set_keymap("n", "<Space>e", "<cmd>:NvimTreeToggle<CR>", {})

[kyazdani42]

@alex-courtis could this be caused by #1618?

[alex-courtis]

@alex-courtis could this be caused by #1618?

Unfortunately no; occurs at 7282f7d

Digging deeper: _prevent_buffer_override calls open-file which obeys quit_on_open and closes the window. Works on my machine.

PR please.