vsplit always opens to the left, can it be on the right?

[ZacharyRizer]

Description

When I'm over a file in nvim-tree and press to open it in a vsplit, I want the file to open the right of the current file I have open. But it always is placed to the left of the current file. I'm sure this is a config setting I'm missing.

Neovim version

NVIM v0.9.0-dev-5-g9353e2f7e
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by root@FM-WYN2K2JQ9D

Operating system and version

macOS 12.4

nvim-tree version

7282f7d

Minimal config

vim.opt.splitbelow = true
vim.opt.splitright = true

local tree_cb = require 'nvim-tree.config'.nvim_tree_callback
require('nvim-tree').setup({
    actions             = {
        open_file = { quit_on_open = true },
    },
    renderer            = {
        indent_markers = { enable = true }
    },
    respect_buf_cwd     = true,
    update_cwd          = true,
    update_focused_file = { enable = true, update_cwd = true },
    view                = {
        adaptive_size = true,
        mappings = {
            custom_only = false,
            list = {
                { key = "<CR>", cb = tree_cb("edit") },
                { key = "h", cb = tree_cb("close_node") },
                { key = "l", cb = tree_cb("open_node") },
                { key = "<BS>", cb = tree_cb("dir_up") },
                { key = "?", cb = tree_cb("toggle_help") },
                { key = "<C-e>", cb = tree_cb("close") },
                { key = "<C-s>", cb = tree_cb("split") },
            }
        },
        width = 35,
        side = 'right',
    },
})

Steps to reproduce

1. have a file open in vim buffer current_file
2. :NvimTreeOpen
3. navigate to file
4. <C-v> to open in vsplit

Expected behavior

File opens to the right of current_file

Actual behavior

File opens to the left of current_file

[kyazdani42]

see :help splitright

[ZacharyRizer]

So as I showed in the original post in the minimal init.lua, I have splitbelow and splitright both set to true. But the buffer still opens to the left. @kyazdani42

[ZacharyRizer]

As an update, out of curiosity I changed the location of the nvim tree from the right to the left. When nvim-tree is on the left, vsplit works as expected with splitright = true. When nvim tree is on the right, vsplit opens on the left with splitright=true.

[alex-courtis]

Boiled this one down:

Default setup with vim.opt.splitright = false and vim.opt.splitbelow = false

<C-x> opens the new window below.
<C-v> opens the new window to the right.

This is a regression.

[kyazdani42]

I use nvim-tree on the right, i do set splitright to false, it work just fine though.

[kyazdani42]

well so this is expected, since when opening, depending on where the tree should be placed, the vsplit action will split to let the tree stay where it supposed to be.

  local do_split = mode == "split" or mode == "vsplit"
  local split_side = (view.View.side == "right") and "aboveleft" or "belowright"

This is expected behavior, since why would you open file on the left if you want to set the tree to be on the right ?
Closing, if you need to introduce a new behavior, please open a new PR :)

[kassio]

This is expected behavior, since why would you open file on the left if you want to set the tree to be on the right ?

I have the tree in the right and also have splitright set. I would expect to hit c-v and open the split on the right of the last focused file (not on the right of the tree).

How do I achieve this behaviour without changing the splitright, since I also split manually or with other plugins that I'd like to keep respecting this value?

[alex-courtis]

I have the tree in the right and also have splitright set. I would expect to hit c-v and open the split on the right of the last focused file (not on the right of the tree).

Also a picked window.

[alex-courtis]

I'm not quite sure things are working correctly with splitright, regardless of view.side. The exectation here is that the split occurs relative to the last or picked window rather than the nvim-tree window.

Here's what normally happens when using <C-w>v
splitright is obeyed relative to the current window.

Here's a similar case with nvim-tree defaults <C-v>
splitright is not set, however the new window is always opened on the right.