Collected Diagnostic Sign Issues

[alex-courtis]

There are some issues with diagnostic sign visibility and correctness at fd2332a

Collect any bugs discovered in here.

I have seen some sporadic problems with signs not updating, however I have not been able to reproduce.

[alex-courtis]

#1157 (#1174) has been resolved

[alex-courtis]

#1213 has been raised however has no reproducer

Update: not an nvim-tree bug

[kyazdani42]

I think we could move the diagnostics update into the renderer actually, it'd be less inaccurate.

[alex-courtis]

I think we could move the diagnostics update into the renderer actually, it'd be less inaccurate.

Yes.

Having the renderer able to render indicators in the signs column would be useful: we could then put other indicators e.g. git in there.

[alex-courtis]

There are timing issues with diagnostics, that we don't see with other signs e.g. git. The diagnostics are often not updated until after the tree is rendered. This is a poor user experience.

We are able to handle git changes perfectly as we are reacting to all events that cause changes to git signs e.g. buffer writes. Diagnostics are lazy and late.

Improvement:
Render the diagnostics upon change, rather than just on tree render.
For nvim lsp we can use vim.lsp.diagnostic.on_publish_diagnostics
For coc we can use the CocDiagnosticChange autocommand; there is no lua api

[alex-courtis]

#1243 updates on CocDiagnosticChange