Coc-diagnostics not functioning

[green726]

Description

Coc diagnostics are not showing in Nvim-tree

Coc java diagnostics are not displaying in the nvim-tree
As can be seen in the below image, there is an error detected by Coc however it is not displayed in nvim-tree

I printed in several spots of the Nvim-tree source code, and the issue seems to be that the utils.find_node function in diagnostics.lua is returning nil.

below image is with the minimal config:

Neovim version

NVIM v0.6.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

Windows 10

nvim-tree version

9eea0ca

Steps to reproduce

1. Install coc-java
2. Open any code, make an error
3. Nvim-tree refresh / open nvim-tree

Expected behavior

Nvim-tree displays coc diagnostic erros

Actual behavior

Nvim tree does not display coc diagnostic errors

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvt-min/site]])
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
	require("packer").startup({
		{
			"wbthomason/packer.nvim",
			"kyazdani42/nvim-tree.lua",
			"kyazdani42/nvim-web-devicons",
			{ "neoclide/coc.nvim", branch = "release" },

			-- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
		},
		config = {
			package_root = package_root,
			compile_path = install_path .. "/plugin/packer_compiled.lua",
			display = { non_interactive = true },
		},
	})
end
if vim.fn.isdirectory(install_path) == 0 then
	print("Installing nvim-tree and dependencies.")
	vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
vim.cmd([[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]])
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
_G.setup = function()
	require("nvim-tree").setup({
		diagnostics = {
			enable = true,
			icons = {
				hint = "",
				info = "",
				warning = "",
				error = "",
			},
		},
	})
end

[alex-courtis]

Thanks for the detailed instructions. Unfortunately I couldn't reproduce with the above configuration, after running :CocInstall coc-java

I have added some diagnostics to a branch so that we may see if we are actually attempting to find a change, or failing to match. Please switch to the https://github.com/kyazdani42/nvim-tree.lua/tree/%231091-diagnostics-logging branch. You can then enable logging via:

        require("nvim-tree").setup({
                log = {
                        enable = true,
                        truncate = true,
                        types = {
                                diagnostics = true,
                        },
                },
...

To switch to the branch you can:

cd <your-plugin-directory>/nvim-tree.lua
git pull
git checkout '#1091-diagnostics-logging'

When done:

git checkout master

Here's what I get when there is a correctly identified problem:

[2022:03:26 16:30:13] [diagnostics] update
[2022:03:26 16:30:13] [diagnostics]  bufname '/tmp/hw/HelloWorld.java' severity 1
[2022:03:26 16:30:13] [diagnostics]   checking node '/tmp/hw/HelloWorld.java'
[2022:03:26 16:30:13] [diagnostics]  matched node '/tmp/hw/HelloWorld.java'

[green726]

Hello, sorry for the late response. This is my log file:

it seems to log

[2022:04:02 17:35:36] [diagnostics]  bufname 'e:\Coding\robotics\2022\MiniSteve\src\main\java\frc\robot\commands\AutoBall.java' severity 4

along with a lot of

[2022:04:02 17:35:36] [diagnostics]   checking node 'E:\Coding\robotics\2022\MiniSteve\.idea'

or something similar

nvim-tree.log

[alex-courtis]

Ouch... windows. I see the window title is powershell, and I'm am concluding that nvim isn't running inside a POSIX shell, hence the windows style path names.

I was under the impression that windows users would run nvim inside a shell like bash, which would provide "proper" paths.

It looks like we have a mismatch in the case of the buffer and the node. I'll investigate that.

[alex-courtis]

I have "canonicalised" the buffer and node paths before matching, on the above branch.

Please update that branch and see if it works for you.

I have tested on linux but cannot test on windows.

[alex-courtis]

@green726 are you still experiencing this problem?

Merging #1170 with the logging and canonical paths.