Skip to content

feat(mappings): open at point opens files #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

moreka
Copy link
Contributor

@moreka moreka commented Feb 18, 2025

Summary

Suppose you want to link to a PDF file on your system. If the (relative) file path does not include spaces, you can use gx mapping from neovim. However, when we have a nice url handler in orgmode.nvim, we can leverage that and pass the parsed url to vim.ui.open (same function that gx calls).
Currently, only urls that start with / or ~ or . are considered "files".

Related Issues

Related #

Closes #

Changes

No changes in the api or the url finding mechanism. Only in open_at_point function of the OrgMappings object.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

Suppose you want to link to a PDF file on your system. If the (relative)
file path does not include spaces, you can use `gx` mapping from neovim.
However, when we have a nice url handler in orgmode.nvim, we can
leverage that and pass the parsed url to `vim.ui.open` (same function
that `gx` calls).
Currently, only urls that start with `/` or `~` or `.` are considered
"files".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant