Skip to content

refactor: replace deprecated vim.loop with vim.uv #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

broken-pen
Copy link
Contributor

Summary

Replace vim.loop with vim.uv. The former has been deprecated since 0.10, which is our minimum version, as far as I can tell.

Related Issues

None

Changes

  • replaced vim.loop with vim.uv in manual search & replace
  • scripts/minimal_init.lua also had its quotes changed by Stylua
  • Running Stylua inside scripts/ produced a lot of changes; I left those in other files out to avoid cluttering the diff.
  • There are two files1 with lines local uv = vim.loop at the top, that now read local uv = vim.uv. I'm not sure about the purpose of these (in Python, you'd do this to avoid repeated attribute lookups, which can be costly), so I left them as is.
  • where those files still used vim.loop, I replaced it with uv, not vim.uv for consistency

Checklist

I confirm that I have:

  • Followed the Conventional Commits specification (e.g., feat: add new feature, fix: correct bug, docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with make test.
  • Checked for breaking changes and documented them, if any.

Footnotes

  1. lua/orgmode/utils/fs.lua and lua/orgmode/utils/treesitter/install.lua

Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kristijanhusak kristijanhusak merged commit 695423e into nvim-orgmode:master Feb 3, 2025
6 checks passed
@broken-pen broken-pen deleted the refactor/remove-vim-loop branch February 4, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants