Skip to content

feat: miragte from auth module v4 to v5 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2021

Conversation

JoaoPedroAS51
Copy link
Contributor

@JoaoPedroAS51 JoaoPedroAS51 commented May 1, 2020

This PR migrate from auth module v4 to v5. It also add referer and x-xsrf-token headers to work with laravel sanctum provider.

Closes #10

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
  Branches         1         1           
=========================================
  Hits            10        10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b525a68...66e0111. Read the comment docs.

JoaoPedroAS51 and others added 2 commits May 1, 2020 17:28
Co-authored-by: radudiaconu0 <radu0071@gmail.com>
Co-authored-by: radudiaconu0 <radu0071@gmail.com>
@ricardogobbosouza
Copy link
Member

Hi @JoaoPedroAS51
It looks good, can we merge?

@JoaoPedroAS51
Copy link
Contributor Author

Hi @ricardogobbosouza! Unfortunately we can't merge it yet. We are making more refactors before release v5 and I will probably need to update this PR again :)

@iranagame
Copy link

Any update on this!?
We're using auth-next because of token refresh capability and we still have problem with laravel-echo, I have to move our app to production in few days and still didn't find any solution to support this lib as well!!!

@iranagame
Copy link

@JoaoPedroAS51
Copy link
Contributor Author

Hi @iranagame! You can use my fork until we merge this PR :)

Just add something like "@nuxtjs/laravel-echo": "JoaoPedroAS51/laravel-echo#feat/auth-v5" to your package.json

@aaronhuisinga
Copy link

I believe this changed the method for getting the token from $auth.token.get() to $auth.strategy.token.get(). Due to this change, this PR is currently broken. I left a comment on the plugin.js file with a fix that I can verify works.

@JoaoPedroAS51 can you take a verify my fix is correct and update the code? We're trying to use this package with Auth v5 and cannot until this is fixed. Thanks so much!

@JoaoPedroAS51
Copy link
Contributor Author

@aaronhuisinga Done! :)

@JoaoPedroAS51
Copy link
Contributor Author

@ricardogobbosouza Can this package have a beta version? That way we could merge this PR :)

@aaronhuisinga
Copy link

Thanks @JoaoPedroAS51!

@ricardogobbosouza
Copy link
Member

Sure @JoaoPedroAS51
I'll do it this week

@JoaoPedroAS51 JoaoPedroAS51 marked this pull request as ready for review October 17, 2020 16:13
@aaronhuisinga
Copy link

Thanks so much for all your work on this @JoaoPedroAS51 and @ricardogobbosouza!

@aaronhuisinga
Copy link

@ricardogobbosouza Any plans to get this merged into a pre-release version?

@ricardogobbosouza
Copy link
Member

Hi @aaronhuisinga
I'll do it until the end of January
Sorry for the delay

Copy link

@jalallinux jalallinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its good and work

@ricardogobbosouza
Copy link
Member

ricardogobbosouza commented Mar 29, 2021

Apologies for the delay
Releasing an alpha version today 😄

@ricardogobbosouza ricardogobbosouza merged commit 31a1098 into nuxt-community:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compability with new laravel's airlock feature
5 participants