-
Notifications
You must be signed in to change notification settings - Fork 30
feat: miragte from auth module v4 to v5 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: miragte from auth module v4 to v5 #14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 10 10
Branches 1 1
=========================================
Hits 10 10 Continue to review full report at Codecov.
|
78f1614
to
79c7b36
Compare
Co-authored-by: radudiaconu0 <radu0071@gmail.com>
Co-authored-by: radudiaconu0 <radu0071@gmail.com>
15cc82b
to
6380e97
Compare
Hi @JoaoPedroAS51 |
Hi @ricardogobbosouza! Unfortunately we can't merge it yet. We are making more refactors before release v5 and I will probably need to update this PR again :) |
Any update on this!? |
Hi @iranagame! You can use my fork until we merge this PR :) Just add something like |
I believe this changed the method for getting the token from @JoaoPedroAS51 can you take a verify my fix is correct and update the code? We're trying to use this package with Auth v5 and cannot until this is fixed. Thanks so much! |
@aaronhuisinga Done! :) |
@ricardogobbosouza Can this package have a beta version? That way we could merge this PR :) |
Thanks @JoaoPedroAS51! |
Sure @JoaoPedroAS51 |
Thanks so much for all your work on this @JoaoPedroAS51 and @ricardogobbosouza! |
@ricardogobbosouza Any plans to get this merged into a pre-release version? |
Hi @aaronhuisinga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its good and work
Apologies for the delay |
This PR migrate from auth module v4 to v5. It also add referer and x-xsrf-token headers to work with laravel sanctum provider.
Closes #10