Skip to content

BLD: use macos-11 image on azure, macos-1015 is deprecated #22043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2022
Merged

BLD: use macos-11 image on azure, macos-1015 is deprecated #22043

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1123e29
BUILD: use macos-11 image on azure, macos-1015 is deprecated
mattip Jul 25, 2022
81842f6
add LIBRARY_PATH
mattip Aug 16, 2022
07a4352
add debug printing
mattip Aug 16, 2022
2e950b2
remove part of CI debugging
mattip Aug 16, 2022
d7b407a
add comment from review
mattip Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,7 @@ stages:

- job: macOS
pool:
# NOTE: at time of writing, there is a danger
# that using an invalid vmIMage string for macOS
# image silently redirects to a Windows build on Azure;
# for now, use the only image name officially present in
# the docs even though i.e., numba uses another in their
# azure config for mac os -- Microsoft has indicated
# they will patch this issue
vmImage: 'macOS-1015'
vmImage: 'macOS-11'
strategy:
maxParallel: 3
matrix:
Expand Down Expand Up @@ -205,9 +198,14 @@ stages:
- script: python runtests.py -g --refguide-check
displayName: 'Run Refguide Check'
condition: eq(variables['USE_OPENBLAS'], '1')
- script: python runtests.py -n --mode=full -- -rsx --junitxml=junit/test-results.xml
- script: |
echo LIBRARY_PATH ${LIBRARY_PATH}
python runtests.py -n --mode=full -- -rsx --junitxml=junit/test-results.xml
displayName: 'Run Full NumPy Test Suite'
condition: eq(variables['USE_OPENBLAS'], '1')
env:
# gfortran installed above adds -lSystem, so this is needed to find it (gh-22043)
LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about above this line adding:

# The Python install in GitHub Actions adds `-lSystem`, which fails without adding this (see gh-22043)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is coming from the macOS-provided python, rather from gcc/gfortran (as opposed to clang, which does not add it). I did not find SHLIBS in NumPy nor in distutils/setuptools, and the stack overflows I linked to did not mention python. Adding a comment in that vein.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. that's a gfortran that anyway needs an update soon, so hopefully that goes away in the next update

- bash: python tools/openblas_support.py --check_version
displayName: 'Verify OpenBLAS version'
condition: eq(variables['USE_OPENBLAS'], '1')
Expand Down