Skip to content

fix nan comparison test #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix nan comparison test #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8cb595
fix nan comparison test
ngoldbaum Mar 5, 2025
ea3653a
turn off sanitizers in CI
ngoldbaum Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ jobs:
then
rm -r build
fi
meson setup build -Db_sanitize=address,undefined
meson setup build
python -m build --no-isolation --wheel -Cbuilddir=build --config-setting='compile-args=-v' -Csetup-args="-Dbuildtype=debug"
find ./dist/*.whl | xargs python -m pip install
- name: Run stringdtype tests
working-directory: stringdtype
run: |
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes
pytest -s -vvv --color=yes
pip uninstall -y pandas
ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes
pytest -s -vvv --color=yes
6 changes: 4 additions & 2 deletions quaddtype/tests/test_quaddtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ def test_unary_ops(op, val, expected):


def test_nan_and_inf():
assert (QuadPrecision("nan") != QuadPrecision("nan")) == (
QuadPrecision("nan") == QuadPrecision("nan"))
# NaN should not equal itself
assert QuadPrecision("nan") != QuadPrecision("nan")

# Test infinity comparisons
assert QuadPrecision("inf") > QuadPrecision("1e1000")
assert QuadPrecision("-inf") < QuadPrecision("-1e1000")

Expand Down