Skip to content

ENH: Test should run regularly from cron #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 8, 2022

This does the bare minimum of enabling cron testing, and I don't think will be controversial. It maybe optimized later to cut back on the number of jobs being run (but maybe that's better done after/in #146 when e.g. developer and/or pre-release version of dependencies are added, etc.)

@bsipocz bsipocz marked this pull request as ready for review September 8, 2022 00:30
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsipocz , this is definitely something we want to do.

One thing I'd like to figure out is what to do when a scheduled job fails. AIUI, if a scheduled job failed at this point, you (and only you) would get an email since you were the last person to touch the cron syntax.

IMO the nicest solution would be to automatically generate an issue when a scheduled job fails; that way everyone who is watching the repo would be notified. Other solutions might be to a) add more devs to the notifications list and/or b) add a status badge to the readme.

I definitely prefer the auto-issue solution, though I don't know exactly how to implement it (maybe this action is a good place to start?). Of course, we don't have to figure this out right now - I'm happy to merge if you don't mind being the point-of-contact for failing scheduled jobs for a bit - just LMK!

@bsipocz
Copy link
Member Author

bsipocz commented Sep 8, 2022

One thing I'd like to figure out is what to do when a scheduled job fails. AIUI, if a scheduled job failed at this point, you (and only you) would get an email since you were the last person to touch the cron syntax.

Thanks for digging that info up, I was puzzled at another repo where I'm admin, yet never received the cron notifications.

@bsipocz
Copy link
Member Author

bsipocz commented Sep 8, 2022

I can try and look into the auto issue opening, but also I'm totally fine being the one getting the default notifications in the meantime.

basically, my gh notifications inbox is the only one I reasonably manage as zero inbox, so will certainly notice and can open an issue manually if needed.

@rossbar
Copy link
Collaborator

rossbar commented Sep 8, 2022

but also I'm totally fine being the one getting the default notifications in the meantime.

Great! Let's get this in then and figure out the notifications piece in a follow-up. Thanks @bsipocz !

@rossbar rossbar merged commit 87be1e4 into numpy:main Sep 8, 2022
@bsipocz bsipocz deleted the gha_adding_cron branch December 21, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants