-
-
Notifications
You must be signed in to change notification settings - Fork 51
Replaces jshint with eslint #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
e650264
9ebf817
0cf3b11
b4e344d
f57f4c3
615bd75
c0e4ef1
9775b39
391fbef
2e4d14f
12f0a80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
{ | ||
"extends": "eslint:recommended", | ||
"env": { | ||
"node": true, | ||
"mocha": true, | ||
"es6": true | ||
}, | ||
"parserOptions": { | ||
"ecmaVersion": 9, | ||
"sourceType": "module", | ||
"ecmaFeatures" : { | ||
"globalReturn": false, | ||
"impliedStrict": true, | ||
"jsx": false | ||
} | ||
}, | ||
"rules": { | ||
"indent": [ | ||
"error", | ||
2 | ||
], | ||
"linebreak-style": [ | ||
"error", | ||
"unix" | ||
], | ||
"quotes": [ | ||
"error", | ||
"single" | ||
], | ||
"semi": [ | ||
"error", | ||
"always" | ||
], | ||
"no-console": "off", | ||
"no-unused-vars": [ | ||
"error", | ||
{ | ||
"vars": "all", | ||
"args": "none", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also think we should throw on unused args, at least the jshint did that before There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally don't think we should throw, it should be a warning. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally, I'd like to keep it this way. Though an arg may not be used it makes a function a bit more expressive when you can see what is available. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jwerre I thought this is thrown when an arg is defined but not used in the function body like so: function dosomething (foo, bar) {
console.log(foo) // bar is defined as arg but never used in the function
} |
||
"ignoreRestSiblings": false | ||
HappyZombies marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
] | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ npm-debug.log*~ | |
auto-save-list | ||
tramp | ||
.\#* | ||
.vscode | ||
|
||
# Org-mode | ||
.org-id-locations | ||
|
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.