refactor: Remove util.inherits #70 #109

dsschiramm · 2021-12-18T22:17:52Z

Summary

Remove util.inherits
Use ES6 Class syntax with extends instead of utils.inherits

Linked issue(s)

#70

Involved parts of the project

Added tests?

Yes, added test to validate OAuthError constructor and properties in test/unit/errors/oauth-error_test.js

OAuth2 standard

Reproduction

Checkout this branch and run the tests.

Uzlopak

If you follow my comments below the tests will all pass

lib/errors/access-denied-error.js

lib/errors/oauth-error.js

Uzlopak · 2021-12-18T22:52:07Z

Also please run one time "npm run lint:fix" so that all linting errors go away.

Uzlopak · 2021-12-18T23:03:05Z

@dsschiramm
Why did you close this?

dsschiramm · 2021-12-18T23:20:05Z

@dsschiramm Why did you close this?

I made a mistake, I'm fixing it, I'll resubmit the pull request later.

Uzlopak · 2021-12-18T23:21:35Z

You could have kept it open or made it a draft. Then everytime you would push into your repo/branch it would automatically show up here.

dsschiramm · 2021-12-18T23:29:47Z

You could have kept it open or made it a draft. Then everytime you would push into your repo/branch it would automatically show up here.

Got it, thanks I didn't know, I'll open it and make the corrections.

dsschiramm · 2021-12-19T03:27:54Z

@Uzlopak could you review one more time ?

jankapunkt · 2021-12-19T09:46:39Z

Hey @dsschiramm thanks a lot for your contribution. Can you please edit your PR and fill out the template sections (summary, linked issues etc.) so we as reviewers can easily step in see what's going on.

lib/errors/oauth-error.js

package.json

jankapunkt · 2022-01-07T09:13:52Z

@dsschiramm we are back in the new year, your PR is not forgotten ;-)

jankapunkt · 2022-02-02T01:02:42Z

I will first create the 4.2.0 release, because it contains important fixes. After that we can check on code-improvements as this one.

# Conflicts: # lib/grant-types/refresh-token-grant-type.js # package-lock.json

jankapunkt · 2023-03-21T20:49:24Z

@Uzlopak as far as I can see all changes were addressed and this can be merged, once you approve

jankapunkt · 2023-05-26T09:30:12Z

@Uzlopak friendly ping

Uzlopak

pong ;)

LGTM

Merge dev into master

Bumps [sinon](https://github.com/sinonjs/sinon) from 13.0.1 to 15.1.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v13.0.1...v15.1.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [chai](https://github.com/chaijs/chai) from 4.3.4 to 4.3.7. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md) - [Commits](chaijs/chai@v4.3.4...v4.3.7) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…yarn/sinon-15.1.0 build(deps-dev): bump sinon from 13.0.1 to 15.1.0

Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.2.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v9.2.2...v10.2.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…yarn/mocha-10.2.0 build(deps-dev): bump mocha from 9.2.2 to 10.2.0

…yarn/chai-4.3.7 build(deps-dev): bump chai from 4.3.4 to 4.3.7

Bumps [eslint](https://github.com/eslint/eslint) from 8.4.1 to 8.41.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.4.1...v8.41.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…yarn/eslint-8.41.0 build(deps-dev): bump eslint from 8.4.1 to 8.41.0

The base branch was changed.

Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.42.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.41.0...v8.42.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…yarn/eslint-8.42.0 build(deps-dev): bump eslint from 8.41.0 to 8.42.0

jankapunkt · 2023-06-08T06:42:06Z

@dsschiramm it's finally merged 🎉 thanks a lot for your contribution and patience!

refactor: Remove util.inherits node-oauth#70

3a7e198

dsschiramm changed the base branch from master to development December 18, 2021 22:19

Uzlopak requested changes Dec 18, 2021

View reviewed changes

lib/errors/access-denied-error.js Outdated Show resolved Hide resolved

lib/errors/oauth-error.js Outdated Show resolved Hide resolved

lib/errors/oauth-error.js Outdated Show resolved Hide resolved

lib/errors/oauth-error.js Outdated Show resolved Hide resolved

Uzlopak mentioned this pull request Dec 18, 2021

Removed Bluebird and Promisify-Any #107

Closed

dsschiramm closed this Dec 18, 2021

refactor: Remove util.inherits node-oauth#70

9460888

dsschiramm reopened this Dec 18, 2021

daniel.santos added 2 commits December 18, 2021 22:00

refactor: Remove util.inherits node-oauth#70

60afc18

change Object.assign to spread operator

c73b5b2

captureStackTrace removed from OAuthError constructor

1d7b401

jankapunkt linked an issue Dec 19, 2021 that may be closed by this pull request

Remove util.inherits #70

Closed

jankapunkt assigned dsschiramm Dec 19, 2021

jankapunkt added the code quality 🧽 Relating to code quality label Dec 19, 2021

jankapunkt requested changes Dec 19, 2021

View reviewed changes

lib/errors/oauth-error.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

daniel.santos added 2 commits December 21, 2021 00:36

fix super constructor call OAuthError

186d85f

OAuthError unit test

ab48e15

dsschiramm requested review from Uzlopak and jankapunkt December 21, 2021 16:15

revert package.json

c2e6409

jankapunkt added this to the v5 milestone Mar 29, 2022

HappyZombies added the on hold 🛑 We will look into it at a later time label Jun 4, 2022

daniel.santos and others added 2 commits July 22, 2022 02:12

Merge branch 'development-upstream' into development

6536fe2

# Conflicts: # lib/grant-types/refresh-token-grant-type.js # package-lock.json

Merge branch 'development' into development

bb96022

jankapunkt previously approved these changes Mar 21, 2023

View reviewed changes

jankapunkt added dependencies 🔌 Pull requests that update a dependency file completed 😀 Work that has been completed and removed on hold 🛑 We will look into it at a later time labels Mar 21, 2023

jankapunkt modified the milestones: v5, v4.4 Mar 21, 2023

Uzlopak previously approved these changes May 26, 2023

View reviewed changes

jankapunkt and others added 9 commits May 30, 2023 10:38

Merge pull request node-oauth#184 from node-oauth/development

aa386b8

Merge dev into master

Merge pull request node-oauth#185 from node-oauth/dependabot/npm_and_…

f9e53ef

…yarn/sinon-15.1.0 build(deps-dev): bump sinon from 13.0.1 to 15.1.0

Merge pull request node-oauth#186 from node-oauth/dependabot/npm_and_…

d0446f4

…yarn/mocha-10.2.0 build(deps-dev): bump mocha from 9.2.2 to 10.2.0

Merge pull request node-oauth#187 from node-oauth/dependabot/npm_and_…

67340df

…yarn/chai-4.3.7 build(deps-dev): bump chai from 4.3.4 to 4.3.7

Merge pull request node-oauth#188 from node-oauth/dependabot/npm_and_…

a03defc

…yarn/eslint-8.41.0 build(deps-dev): bump eslint from 8.4.1 to 8.41.0

jankapunkt changed the base branch from development to master June 5, 2023 08:15

dependabot bot and others added 3 commits June 5, 2023 18:59

Merge pull request node-oauth#189 from node-oauth/dependabot/npm_and_…

4494564

…yarn/eslint-8.42.0 build(deps-dev): bump eslint from 8.41.0 to 8.42.0

Merge branch 'master' into development

f2f6c21

jankapunkt changed the base branch from master to development June 6, 2023 09:28

Update authorization-code-grant-type.js

e00a630

jankapunkt merged commit 9fd04f6 into node-oauth:development Jun 8, 2023

Uh oh!

refactor: Remove util.inherits #70 #109

refactor: Remove util.inherits #70 #109

Uh oh!

Conversation

dsschiramm commented Dec 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Linked issue(s)

Involved parts of the project

Added tests?

OAuth2 standard

Reproduction

Uh oh!

Uzlopak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uzlopak commented Dec 18, 2021

Uh oh!

Uzlopak commented Dec 18, 2021

Uh oh!

dsschiramm commented Dec 18, 2021

Uh oh!

Uzlopak commented Dec 18, 2021

Uh oh!

dsschiramm commented Dec 18, 2021

Uh oh!

dsschiramm commented Dec 19, 2021

Uh oh!

jankapunkt commented Dec 19, 2021

Uh oh!

Uh oh!

Uh oh!

jankapunkt commented Jan 7, 2022

Uh oh!

jankapunkt commented Feb 2, 2022

Uh oh!

jankapunkt commented Mar 21, 2023

Uh oh!

jankapunkt commented May 26, 2023

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

jankapunkt commented Jun 8, 2023

Uh oh!

Uh oh!

dsschiramm commented Dec 18, 2021 •

edited

Loading

Uzlopak left a comment •

edited

Loading