Skip to content

Insufficient integration tests #219

Closed
@jankapunkt

Description

@jankapunkt

Specify your setup

  • version of @node-oauth/oauth2-server: 5.0.0-rc.1

Describe the bug

The integration tests do not properly cover the regressions, introduced by the switch to native async/await. This is due to the original integration tests do not really test, whether the correct values are passed to the model as most model functions are not covering parameters or return nearly nothing.

This already resulted in:

Proposal:

All integration tests should also cover proper model testing.

We should target this for 5.0.0, because there may be more parts affected as may have been revealed yet.

Metadata

Metadata

Assignees

Labels

bug 🐛Something isn't workingin progress 👨‍💻Currently in progress and is being worked on.security ❗Address a security issuetests 🧪Relates to tests

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions