Skip to content

Create TypeScript declarations from JSDoc #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2020
Merged

Create TypeScript declarations from JSDoc #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b6d49c
remove manual typings
tinovyatkin Jun 8, 2020
a910983
create typings from JSDoc
tinovyatkin Jun 8, 2020
dad79d0
fix param name
tinovyatkin Jun 8, 2020
e0deec8
add typings to gitignore
tinovyatkin Jun 8, 2020
f9142ea
specify TypeScript minimum version
tinovyatkin Jun 8, 2020
f5213ec
move typescript into devDependencies
tinovyatkin Jun 10, 2020
45c301d
Merge branch 'master' into typings-from-jsdoc
tinovyatkin Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,4 @@ typings/
# dotenv environment variables file
.env

# next.js build output
.next
index.d.ts
4 changes: 0 additions & 4 deletions index.d.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class Blob {
*
* @param {number} [start]
* @param {number} [end]
* @param {string} [contentType]
* @param {string} [type]
*/
slice(start = 0, end = this.size, type = '') {
const {size} = this;
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"lint": "xo",
"test": "xo && ava",
"report": "nyc ava",
"coverage": "nyc --reporter json --reporter text ava && codecov -f coverage/coverage-final.json"
"coverage": "nyc --reporter json --reporter text ava && codecov -f coverage/coverage-final.json",
"prepublishOnly": "tsc --declaration --emitDeclarationOnly --allowJs index.js"
},
"repository": "https://github.com/node-fetch/fetch-blob.git",
"keywords": [
Expand All @@ -33,6 +34,7 @@
"get-stream": "^5.1.0",
"node-fetch": "^2.6.0",
"nyc": "^15.0.1",
"typescript": "^3.9.5",
"xo": "^0.32.0"
},
"xo": {
Expand Down