Skip to content

Allow tags and branches arguments to be specified multiple times #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

pdf
Copy link

@pdf pdf commented Jul 5, 2016

This mirrors upstream, though I'm not certain of which git-svn version this
functionality was added.

Fixes #175

The first commit (34ba3f3) just cleans up some lint to stop my editor
complaining, I can push without that if you don't want to take it.

@robinro
Copy link

robinro commented Oct 11, 2016

@nirvdrum Please merge this, the feature is available in git-svn for quite some time and the implementation is backwards-compatible if one specifies only one --branch argument.

@nirvdrum
Copy link
Owner

Thanks. Do you happen to know when the feature was introduced? It'd be helpful to have for documentation. An updated example for the README would be nice as well, but could be added afterwards.

@pdf I'd prefer to merge without the linter fixes. Unfortunately, even the other commit sets off warnings over here because of silly things like the { in your iterator not being separated by a space. I can fix those up easily enough, but I'd rather avoid ping-ponging on style issues. If you can't push the branch without the lint fixes, I'll just cherry-pick the commit.

This mirrors upstream, though I'm not certain of which git-svn version
this functionality was added.

Fixes nirvdrum#175
@pdf pdf force-pushed the multiple_branches_tags branch from 33525f4 to 3dea2bf Compare October 12, 2016 11:58
@pdf
Copy link
Author

pdf commented Oct 12, 2016

Lint commit removed, I think I had a cursory look through the upstream changelogs, but couldn't readily find when the functionality was introduced, pretty sure it was quite some time ago though.

@robinro
Copy link

robinro commented Oct 12, 2016

According to https://git-scm.com/docs/git-svn/1.8.0.3 the option to have multiple branches was already in 1.8 and the manpage history does not get any older. The oldest in-production git version I know is centos6 with 1.7.x, so any reasonable user will have this feature available.

@nirvdrum
Copy link
Owner

Great. Thanks for the follow-up. FYI, I usually use the oldest supported Ubuntu LTS as the lowest common denominator. In this case, that's 12.04, which ships with 1.7.9.5. That's not to say I'm opposed to adding newer features that require newer gits, but I don't want to add anything that will break for people currently using svn2git. This pull request seems backwards compatible, so I'm okay with it.

@mistresseve666
Copy link

+1 to request.

I can't find documentation for 1.7.9.5, but git 1.7.7.2 had support for multiple --tags or --branches.

@nirvdrum nirvdrum merged commit 3d9a510 into nirvdrum:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants