Skip to content

Add support for --password option #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Conversation

edpbx
Copy link

@edpbx edpbx commented Apr 15, 2015

git-svn doesn't support yet but it will!

@edpbx
Copy link
Author

edpbx commented Apr 15, 2015

@nirvdrum it would be really helpful if you could merge this so it's authoritative. svn itself supports it, and soon enough git-svn will.

@nirvdrum
Copy link
Owner

I take it's backwards-compatible? No-op is fine. I just don't want to raise exceptions on people running older versions of git-svn.

@edpbx
Copy link
Author

edpbx commented Apr 16, 2015

It will cause some kind of problem if people specify a --password and installed svn doesn't support that. However, surely no harm done?

@edpbx
Copy link
Author

edpbx commented Apr 17, 2015

Remember, that exception could only happen if people

  • have a pre-2008 (at least) copy of SVN
  • specify a --password

Is this really a problem? The error message will surely be very clear.

@nirvdrum
Copy link
Owner

That should be fine then. I have a full matrix of versions I end up testing against. Since Ubuntu 10.04 LTS is now rolling out of its support phase, that will bump a bunch of people up version-wise anyway.

Can you please make a documentation addition for the new option as well?

@edpbx
Copy link
Author

edpbx commented Apr 17, 2015

@nirvdrum Done!

@nirvdrum
Copy link
Owner

Thanks!

nirvdrum added a commit that referenced this pull request Apr 17, 2015
Add support for --password option
@nirvdrum nirvdrum merged commit 526df23 into nirvdrum:master Apr 17, 2015
@nirvdrum
Copy link
Owner

I'll try to take a pass through some other stuff this weekend and do a new release.

@edpbx
Copy link
Author

edpbx commented Apr 17, 2015

👍

@edpbx edpbx deleted the passwordoption branch April 17, 2015 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants