-
Notifications
You must be signed in to change notification settings - Fork 533
ENH: Added a datagrabber capable of grabbing files from an SSH access #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6d7af13
ENH: Added a datagrabber capable of grabbing files from an SSH access
demianw 7252f2e
ENH: Improved style taking advantage of inheritance
demianw 33d9217
BUG: Corrected typo
demianw 303ba30
ENH: Now the case when there is no SSH forwarding is well handled
demianw 652c139
ENH: Incorporated mwaskom's suggestions
demianw 7e24f28
ENH: Changed the checks for the paramiko library so doctests pass eve…
demianw 5156fa4
BUG: Corrected inheritance bug
demianw 4634f5a
Merge branch 'master' into SSHDataGrabber
demianw 4934023
ENH: Added a description of the new interface in the CHANGES file
demianw 854e510
ENH: Added a description of the new interface in the CHANGES file, mo…
demianw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be annoying/confusing if the SSHGrabber crashes mid-workflow because this module wasn't available, seems better to raise in
__init__
if it's missing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any recommendation on the type of exception you'd think the most appropriate to raise here? ImportError seems the more appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'd define a boolean called
_has_paramiko
based off the results of this try/except and then raiseImportError
fromSSHDataGrabber.__init__
if it is False.Does nothing in the standard library handle ssh stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope nothing in the standard library handles it, specially the proxy which is needed in many clusters as the processing nodes have to go through the head node to exit the network in many cases.
I did it a bit different with calling a paramiko line and checking for name error
try:
paramiko
except NameError:
raise ImportError()