Partial revert of imoports in nipype namespace #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm ok with this. could you fix the failing tests? |
|
Yep doing that now, figured it was easier to let travis catch them. |
|
Tests are green. |
satra
added a commit
that referenced
this pull request
May 17, 2014
Partial revert of imoports in nipype namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to my recent comment on #784. It also closes #784.
This means that you have to specifically ask to import interfaces to any external code (whether or not that code is Python-based), but the major components of nipype itself are still available in the nipype namespace.
This brings the import wall time down to 696 ms from 16.6 s on my system.