Skip to content

[FIX] change ANTS number_of_time_steps from Float to Int #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

BenjaminMey
Copy link
Contributor

Summary

Fixes #3117 .

List of changes proposed in this PR (pull-request)

  • Change the trait type for ANTS number_of_time_steps from traits.Float to traits.Int

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member

In case you missed from #3117 (comment), if you want this to work for Python 2.7, you're going to need to rebase onto maint/1.3.x.

See https://github.com/nipy/nipype#python-2-statement

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #3118 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3118      +/-   ##
==========================================
- Coverage   67.84%   67.79%   -0.05%     
==========================================
  Files         295      295              
  Lines       39304    39318      +14     
  Branches     5178     5179       +1     
==========================================
- Hits        26664    26654      -10     
- Misses      11934    11954      +20     
- Partials      706      710       +4
Flag Coverage Δ
#smoketests 51.05% <100%> (-0.18%) ⬇️
#unittests 65.05% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/ants/registration.py 72.83% <100%> (ø) ⬆️
nipype/interfaces/dcm2nii.py 58.68% <0%> (-6.11%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 59.29% <0%> (-3.52%) ⬇️
nipype/utils/provenance.py 82.58% <0%> (-1.3%) ⬇️
nipype/info.py 93.82% <0%> (-0.21%) ⬇️
nipype/pipeline/engine/nodes.py 83.14% <0%> (-0.17%) ⬇️
nipype/__init__.py 58.06% <0%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e30cc...fd28fa9. Read the comment docs.

@effigies
Copy link
Member

Merging. I notice that this is a deprecated interface, and that the recommended is ants.Registration, so you might want to consider moving to that, regardless.

@effigies effigies merged commit 76d8e88 into nipy:master Dec 30, 2019
@effigies effigies added this to the 1.4.1 milestone Jan 6, 2020
@effigies effigies mentioned this pull request Jan 6, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ANTS InputSpec number_of_time_steps incorrect trait type
2 participants