Skip to content

Change max_sh variable in reconst.py to accept a list; keep %d option #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lucindasisk
Copy link
Contributor

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@oesteban
Copy link
Contributor

Is it the case for EstimateFOD you are updating here that now it accepts max_sh not to be set to trigger the "auto" mode? (related #2940)

@effigies
Copy link
Member

Closing in favor of #2990.

@effigies effigies closed this Aug 16, 2019
@effigies
Copy link
Member

@oesteban It can be set to [] if somebody wants... If this is a concern, please follow-up on #2990.

@lucindasisk
Copy link
Contributor Author

lucindasisk commented Aug 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants