Skip to content

[FIX] Remove '=' signs from EddyQuad argument specifications #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2019

Conversation

josephmje
Copy link
Contributor

@josephmje josephmje commented Jun 6, 2019

Addresses #2935

@effigies
Copy link
Member

effigies commented Jun 6, 2019

You'll need to run make specs.

Michael Joseph and others added 2 commits June 6, 2019 12:12
@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@460c1bb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2941   +/-   ##
=========================================
  Coverage          ?   67.59%           
=========================================
  Files             ?      344           
  Lines             ?    43747           
  Branches          ?     5456           
=========================================
  Hits              ?    29572           
  Misses            ?    13466           
  Partials          ?      709
Flag Coverage Δ
#smoketests 50.37% <ø> (?)
#unittests 65.03% <ø> (?)
Impacted Files Coverage Δ
nipype/interfaces/fsl/epi.py 63.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460c1bb...b989900. Read the comment docs.

@josephmje
Copy link
Contributor Author

Thanks @effigies . I ran make specs and updated the PR.

@josephmje
Copy link
Contributor Author

Just wanted to revisit this. Is this ok the merge now?

@effigies
Copy link
Member

Ah, thanks for the bump. I think this looks reasonable. To be clear, this won't break older versions of eddy_quad?

@josephmje
Copy link
Contributor Author

eddy_quad was only introduced in FSL 6.0. I've tried it on both v6.0 and v6.0.1 and it works fine

@effigies effigies changed the title [FIX] removed '=' signs from eddy_quad inputspec [FIX] Remove '=' signs from EddyQuad argument specifications Jun 25, 2019
@effigies
Copy link
Member

Sounds good. Thanks for the contribution.

@effigies effigies merged commit e722d61 into nipy:master Jun 25, 2019
@effigies effigies added this to the 1.2.1 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants