Skip to content

FIX: Construct MCFLIRT output paths relative to out_file #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

effigies
Copy link
Member

Summary

MCFLIRT creates optional outputs in the same directory as the out_file, regardless of whether that happens in the current working directory.

Fixes #2698.

List of changes proposed in this PR (pull-request)

  • Determine output directory from out_file

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.1.3 milestone Sep 17, 2018
@abelalez
Copy link
Contributor

For my own purpose, I've been trying something identical (abelalez@7eee9ff), just defining: cwd = os.path.dirname(output['out_file'])
I tested it with my data and it worked.

@effigies
Copy link
Member Author

Cool. Thanks for the confirmation. I'll merge this if tests pass.

@effigies effigies merged commit da96356 into nipy:master Sep 18, 2018
@effigies effigies deleted the fix/mcflirt_outputs branch September 18, 2018 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants