Skip to content

DOC: Fix naming of motion parameters (roll/yaw swapped) #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

abelalez
Copy link
Contributor

@abelalez abelalez commented Sep 6, 2018

I've modified the docstring in the function normalize_mc_params, after discussing with @satra.
There was a mismatch in the description of the parameters ry and rz.
ry -> roll, rz -> yaw

Summary

Fixes # .

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

I've modified the docstring in the function normalize_mc_params, after discussing with @satra.
There was a mismatch in the description of the parameters ry and rz.
ry -> roll, rz -> yaw
@effigies effigies changed the title Change in normalize_mc_params DOC: Fix naming of motion parameters (roll/yaw swapped) Sep 6, 2018
@codecov-io
Copy link

Codecov Report

Merging #2696 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2696      +/-   ##
==========================================
+ Coverage    67.6%   67.61%   +<.01%     
==========================================
  Files         340      340              
  Lines       43144    43144              
  Branches     5349     5349              
==========================================
+ Hits        29169    29173       +4     
+ Misses      13273    13269       -4     
  Partials      702      702
Flag Coverage Δ
#smoketests 50.58% <ø> (ø) ⬆️
#unittests 65.1% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
nipype/utils/misc.py 64.15% <ø> (ø) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 63.69% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886c081...5ae38c5. Read the comment docs.

@effigies effigies merged commit fa0a101 into nipy:master Sep 6, 2018
@effigies
Copy link
Member

effigies commented Sep 6, 2018

Thanks!

@abelalez abelalez deleted the patch-1 branch September 6, 2018 23:30
@effigies effigies added this to the 1.1.3 milestone Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants