-
Notifications
You must be signed in to change notification settings - Fork 533
MAINT: Remove ignore_exception and terminal_output traits from input specs #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
- Coverage 67.59% 67.25% -0.35%
==========================================
Files 339 339
Lines 42820 42818 -2
Branches 5290 5290
==========================================
- Hits 28946 28796 -150
- Misses 13192 13271 +79
- Partials 682 751 +69
Continue to review full report at Codecov.
|
Failure was a URL download issue, not related to these changes. Can rebuild before merge, if this passes code review. |
How do people feel about this? Need to merge master, or are we happy with tests as is? |
Ah, @oesteban approved. Merging to get tests moving along on master. |
This one's going to make the most sense to look at as just the first commit as the actual change. Everything else is tests.
Fixes #2554.