Skip to content

MAINT: Remove ignore_exception and terminal_output traits from input specs #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 2, 2018

Conversation

effigies
Copy link
Member

This one's going to make the most sense to look at as just the first commit as the actual change. Everything else is tests.

Fixes #2554.

@effigies effigies added this to the 1.1.0 milestone Jun 16, 2018
@codecov-io
Copy link

codecov-io commented Jun 16, 2018

Codecov Report

Merging #2618 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
- Coverage   67.59%   67.25%   -0.35%     
==========================================
  Files         339      339              
  Lines       42820    42818       -2     
  Branches     5290     5290              
==========================================
- Hits        28946    28796     -150     
- Misses      13192    13271      +79     
- Partials      682      751      +69
Flag Coverage Δ
#smoketests 48.32% <100%> (-2.44%) ⬇️
#unittests 65.1% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/afni/preprocess.py 81.48% <ø> (-0.03%) ⬇️
nipype/interfaces/base/core.py 89.85% <ø> (+0.14%) ⬆️
nipype/interfaces/base/specs.py 93.1% <100%> (-0.04%) ⬇️
nipype/workflows/fmri/fsl/preprocess.py 72.67% <0%> (-13.39%) ⬇️
nipype/pipeline/plugins/multiproc.py 75.59% <0%> (-6.55%) ⬇️
nipype/workflows/fmri/fsl/estimate.py 61.97% <0%> (-2.82%) ⬇️
nipype/interfaces/fsl/model.py 77.91% <0%> (-2.71%) ⬇️
nipype/interfaces/fsl/preprocess.py 80.33% <0%> (-2.27%) ⬇️
nipype/workflows/fmri/spm/preprocess.py 70.4% <0%> (-2.05%) ⬇️
nipype/utils/config.py 65.21% <0%> (-1.64%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae8b20...a663f43. Read the comment docs.

@effigies
Copy link
Member Author

Failure was a URL download issue, not related to these changes. Can rebuild before merge, if this passes code review.

@effigies
Copy link
Member Author

effigies commented Jul 2, 2018

How do people feel about this? Need to merge master, or are we happy with tests as is?

@effigies
Copy link
Member Author

effigies commented Jul 2, 2018

Ah, @oesteban approved. Merging to get tests moving along on master.

@effigies effigies merged commit fbc8944 into nipy:master Jul 2, 2018
@effigies effigies deleted the deprecations branch July 2, 2018 16:04
@effigies effigies mentioned this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants