Skip to content

fix: some lgtm errors #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2018
Merged

fix: some lgtm errors #2478

merged 5 commits into from
Mar 14, 2018

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Mar 1, 2018

@@ -1202,6 +1202,9 @@ def normalize_tpms(in_files, in_mask=None, out_files=[]):

in_files = np.atleast_1d(in_files).tolist()

if not out_files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if out_files is None

@satra
Copy link
Member

satra commented Mar 7, 2018

@mgxd - can you merge with master

@effigies effigies added this to the 1.0.2 milestone Mar 7, 2018
@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #2478 into master will increase coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
+ Coverage   66.66%   66.67%   +0.01%     
==========================================
  Files         328      327       -1     
  Lines       42529    42417     -112     
  Branches     5278     5262      -16     
==========================================
- Hits        28350    28280      -70     
+ Misses      13500    13457      -43     
- Partials      679      680       +1
Flag Coverage Δ
#smoketests 50.83% <23.52%> (+0.04%) ⬆️
#unittests 64.01% <40%> (+0.04%) ⬆️
Impacted Files Coverage Δ
nipype/pipeline/plugins/__init__.py 100% <ø> (ø) ⬆️
nipype/info.py 85.07% <ø> (-0.22%) ⬇️
nipype/interfaces/nipy/preprocess.py 48.27% <ø> (+0.71%) ⬆️
nipype/interfaces/ants/registration.py 73.18% <ø> (+0.09%) ⬆️
nipype/pipeline/engine/base.py 88.46% <ø> (+4.82%) ⬆️
nipype/pipeline/engine/utils.py 82.24% <0%> (-0.1%) ⬇️
nipype/interfaces/cmtk/cmtk.py 18.65% <0%> (-0.04%) ⬇️
nipype/utils/filemanip.py 77.59% <0%> (+1.46%) ⬆️
nipype/pipeline/plugins/ipython.py 22.82% <0%> (-0.51%) ⬇️
nipype/interfaces/cmtk/nx.py 19.24% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88dbce1...5007c99. Read the comment docs.

@mgxd mgxd changed the title wip+fix: some lgtm errors fix: some lgtm errors Mar 8, 2018
@satra satra merged commit 27b33ef into nipy:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants