Skip to content

fix: set _id property of cloned node too #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2018
Merged

fix: set _id property of cloned node too #2432

merged 3 commits into from
Feb 9, 2018

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Feb 8, 2018

Fixes #2431 .

@mgxd mgxd requested a review from oesteban February 8, 2018 22:02
oesteban
oesteban approved these changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor stylistic comments on the new test.

nipype/pipeline/engine/tests/test_base.py Outdated
inputnode.iterables = [('subject', subject_list)]

node_1 = pe.Node(niu.Function(input_names='string',
output_names= 'string',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces here and lines 83, 87, 88.

@satra satra merged commit db26703 into nipy:master Feb 9, 2018
@mgxd mgxd deleted the fix/clone branch February 9, 2018 20:32
@effigies effigies added this to the 1.0.1 milestone Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mgxd @oesteban @effigies @satra